Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for UI rotation gestures #123

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cordosvictor
Copy link

No description provided.

@cordosvictor cordosvictor changed the title Added support for the following UI rotation gesture events: begin, change and end. Added support for UI rotation gestures Dec 12, 2017
@macrozone
Copy link
Collaborator

Hi @cordosvictor thanks for your efforts!

personally I think that gesture detection should not be part of this library at all, because there is the panresponder and plenty of other libraries for react-native for that.

rationale: once we add android support, we will have to mimic the ios gesture detection or drop support for this feature, while panresponder has already solved that problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants