Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for properly symbolicating production profiles taken with hermes. In production mode, hermes produces a slightly different profile format, where instead of line + column information it has
funcVirtAddr
andoffset
. As far as I can tell you can easily map this back to line and column by doing:References:
Profiles taken with react-native-release-profiler. An example profile + sourcemap can be found here.
Demo
Speedscope now has first class support for both the raw and transformed hermes profile formats, it was used for the comparisons:
Before:
After: