feat: add automated release workflow #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authenticated clients should be able to trigger a release with a request like: curl -X POST https://api.github.com/repos/react-native-community/template/dispatches \ -H "Accept: application/vnd.github.v3+json" \ -H "Authorization: Bearer $YOUR_TOKEN" \ -d ' "event_type": "publish", "sender": "Some useful identifier", "client_payload": " { "version": "0.75.0-rc.4", "is_latest_on_npm": true } '
blakef
force-pushed
the
feat/add-automated-release-workflow
branch
from
723b0cc
to
832fdea
Compare
cipolleschi
requested changes
Jul 8, 2024
Comment on lines
+22
to
+31
| - name: Move to MAJOR.MINOR-stable or create if it doesn't exist | ||
| run: | | ||
| VERSION=$(grep -E '\d+\.\d+' <<< "$VERSION" | awk '{ print "branch="$0"-stable" }') | ||
| if ! git ls-remote -q --exit-code --heads origin $VERSION > /dev/null; then | ||
| echo "Creating missing release branch \"$VERSION\"" | ||
| git checkout -B "$VERSION" | ||
| git push --set-upstream origin "$VERSION" | ||
| else | ||
| git checkout "$VERSION" | ||
| fi |
There was a problem hiding this comment.
you don't need to do that. The checkout will happen in the right branch automatically.
| git config --global user.email '[email protected]' | ||
| git commit -am "Bumping template to $VERSION" | ||
| git push | ||
| git tag $VERSION |
There was a problem hiding this comment.
with or without the leading v?
Suggested change
| git tag $VERSION | |
| git tag "$VERSION" |
Comment on lines
+49
to
+62
| - name: Publish NPM | ||
| run: npm publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| - name: Set NPM tags | ||
| run: | | ||
| if [[ "$VERSION" == *"rc"* ]]; then | ||
| npm dist-tag add @react-native-community/template@$VERSION next | ||
| fi | ||
| if [[ "$GITHUB_REF_NAME" == *"-stable" ]]; then | ||
| npm dist-tag add @react-native-community/template@$VERSION $GITHUB_REF_NAME | ||
| fi | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Can't we remove these and make the release.yaml job to be triggered on tags, also?
There was a problem hiding this comment.
+1 to this. I think having just the release.yaml workflow do both manual/automatic release is probably the way to go
There was a problem hiding this comment.
Agreed, will do this.
|
This isn't necessary, as we're going to make cutting a MINOR branch on template part of the release process. Then it's just a case of calling the release.yaml workflow. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 15, 2024
Summary: Call the react-native-community/template GHA to trigger a new release when we publish a react-native release. This then waits to confirm that the package is published. See react-native-community/template#36 for the matching change Changelog: [General][Added] trigger template publish Pull Request resolved: #45327 Test Plan: Not sure on the best way forward here. Reviewed By: cipolleschi Differential Revision: D59467829 Pulled By: blakef fbshipit-source-id: 091269e7ecdae5801ac7c03a1ede54452ae99b24
cipolleschi
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 22, 2024
Summary: Call the react-native-community/template GHA to trigger a new release when we publish a react-native release. This then waits to confirm that the package is published. See react-native-community/template#36 for the matching change Changelog: [General][Added] trigger template publish Pull Request resolved: #45327 Test Plan: Not sure on the best way forward here. Reviewed By: cipolleschi Differential Revision: D59467829 Pulled By: blakef fbshipit-source-id: 091269e7ecdae5801ac7c03a1ede54452ae99b24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authenticated clients should be able to trigger a release with a request
like: