Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md, fix a typo #6868

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Update CONTRIBUTING.md, fix a typo #6868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ The team reviews code quality rules including:

- **i18n**: All static copy should use i18next. Include definitions in the appropriate en.json file.

- **a11y**: Code should be accesibility compliant.
- **a11y**: Code should be accessibility compliant.

Reviewers will note any changes that they will want to QA in the app, even if they aren't listed in the testing steps (e.g if the code changes a cart button, ensure that the button still works).

Expand All @@ -123,4 +123,4 @@ Congrats - Once you have all the green lights with an approved PR, you are ready
Does your new feature require new user documentation or developer documentation? Make an issue for that in *reaction-docs*.

### Step 5: Congrats! It's merged. What happens next?
Now that your PR is merged, the feature will be released in the next release.
Now that your PR is merged, the feature will be released in the next release.