Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] style: format #213

Merged
merged 8 commits into from
Jan 5, 2020
Merged

[WIP] style: format #213

merged 8 commits into from
Jan 5, 2020

Conversation

atefBB
Copy link
Contributor

@atefBB atefBB commented Dec 28, 2019

use the Arabic version of ، .

use the Arabic version of `،` .
@asantarissy
Copy link
Member

Thanks @atefBB keep it up 🚀
Please mark the PR as WIP if you're still working on it.

@netlify
Copy link

netlify bot commented Dec 28, 2019

Deploy preview for ar-reactjs ready!

Built with commit c29bb95

https://deploy-preview-213--ar-reactjs.netlify.com

Copy link
Contributor

@mohamedsgap mohamedsgap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep going!

@atefBB
Copy link
Contributor Author

atefBB commented Dec 28, 2019

@asantarissy @mohamedsgap Thank y'all!

@3imed-jaberi 3imed-jaberi changed the title style: format [WIP] style: format Dec 30, 2019
@3imed-jaberi 3imed-jaberi self-assigned this Dec 30, 2019
@atefBB
Copy link
Contributor Author

atefBB commented Jan 1, 2020

@3imed-jaberi

هل مازال العمل جاريا على مراجعة التغييرات في الـPR ؟

Replace `,` with `،`.
Format & review translation & fix spilling errors
content/docs/code-splitting.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mohamedsgap mohamedsgap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good progress so far!! just apply the required changes from @3imed-jaberi

content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Show resolved Hide resolved
@3imed-jaberi 3imed-jaberi added in-review changes-requested update needed This PR needs update since last commit and removed changes-requested update needed This PR needs update since last commit in-review labels Jan 1, 2020
@3imed-jaberi 3imed-jaberi merged commit 9256607 into reactjs:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested update needed This PR needs update since last commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants