Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove broken meetup links #945

Closed

Conversation

juliogarciape
Copy link
Contributor

@juliogarciape juliogarciape commented Oct 3, 2024

I was reviewing the meetups page and noticed that there are many broken links. Several groups that were on meetup.com no longer appear, possibly because they are inactive or have changed their names.

Therefore, I decided to remove those links, as they only redirected to a page like this:

Screenshot

I submitted the same changes to the documentation in English, and they were merged.

I am a native Spanish speaker so if you ever need help updating this repo I'd be happy to help. I am also a member of the ExpressJS Organization where I help with translation and bug fixes in the documentation.

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
es-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 5:48pm

@juliogarciape
Copy link
Contributor Author

juliogarciape commented Oct 15, 2024

@carburo Why? The links are broken and this same change was merged into the official version

@carburo
Copy link
Member

carburo commented Oct 15, 2024

Hi, sorry, I didn't mean to close this one without an explanation, I was closing the stale automated sync PRs and yours got also closed by mistake. Anyways, I'm currently doing the periodic sync with the English repo, so these changes with your original commit will get merged, just not this PR. I haven't had the bandwidth to do the weekly sync, so that's why we still don't have these updates in the repo. Thanks for your contribution!

@juliogarciape
Copy link
Contributor Author

juliogarciape commented Oct 15, 2024

Hi, sorry, I didn't mean to close this one without an explanation, I was closing the stale automated sync PRs and yours got also closed by mistake. Anyways, I'm currently doing the periodic sync with the English repo, so these changes with your original commit will get merged, just not this PR. I haven't had the bandwidth to do the weekly sync, so that's why we still don't have these updates in the repo. Thanks for your contribution!

Oh don't worry, I understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants