-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation of Beta docs importing-and-exporting-components.md #286
Translation of Beta docs importing-and-exporting-components.md #286
Conversation
and the exporting and importing a component section
@galnir some of the checks did not pass is this a problem? |
No not an issue |
Any reason this isn't approved? @galnir |
@@ -4,24 +4,22 @@ title: Importing and Exporting Components | |||
|
|||
<Intro> | |||
|
|||
The magic of components lies in their reusability: you can create components that are composed of other components. But as you nest more and more components, it often makes sense to start splitting them into different files. This lets you keep your files easy to scan and reuse components in more places. | |||
|
|||
הקסם של קומפוננטות טמון בשימוש החוזר שלהם: ניתן ליצור קומפנטטות המורכבות מקומפוננטות אחרות. אבל ככל שאתם מתחילים לקנן יותר ויותר קומפוננטות, לעתים קרובות הגיוני יותר להתחיל לפצל אותם לקבצים שונים. זה יאפשר לכם לשמור על הקבצים שלכם קריאים ולעשות שימוש חוזר בקומפוננטות במקומות נוספים. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
קומפנטטות typo
לקנן
is the right word but it doesn't sound right, we should think of an alternative word/words to describe nesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how was this done in other places in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the previous docs we used לקנן, your PR is the first one that addresses that word on the new beta docs
I think the best translation for that sentence is
אבל ככל שאתם מתחילים להשתמש ביותר ויותר קומפוננטות בתוך קומפוננטות אחרות,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would translate "reusability" as - יכלת שימוש חוזר
* When to use default and named imports and exports | ||
* How to import and export multiple components from one file | ||
* How to split components into multiple files | ||
* מה היא קומפוננטת שורש |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of מה היא קומפוננטת שורש
מה היא קומפוננטת root
קומפוננטת שורש doesn't ring right
* How to split components into multiple files | ||
* מה היא קומפוננטת שורש | ||
* איך לייבא ולייצא קומפוננטה | ||
* מתי נשתמש ביבוא ויצוא דיפולטיבי, ומתי ביבוא ויצוא שמי |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
מתי נשתמש בdefault export ומתי בnamed import ו-export
## The root component file {/*the-root-component-file*/} | ||
|
||
In [Your First Component](/learn/your-first-component), you made a `Profile` component and a `Gallery` component that renders it: | ||
## קומפוננטת השורש {/*the-root-component-file*/} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root
|
||
[בקומפוננטה הראשונה שלכם](/learn/your-first-component) בנית את הקומפוננטה `Profile` ואת הקומפוננטה `Gallery` שמרדנרדת אותה: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
שלך*
מרנדרת*
These currently live in a **root component file,** named `App.js` in this example. In [Create React App](https://create-react-app.dev/), your app lives in `src/App.js`. Depending on your setup, your root component could be in another file, though. If you use a framework with file-based routing, such as Next.js, your root component will be different for every page. | ||
|
||
## Exporting and importing a component {/*exporting-and-importing-a-component*/} | ||
הקומפוננטות האלו כרגע יושבות **בקובץ קומפוננטת השורש** שנקרא `App.js` בדוגמא הזאת. ב[Create React App](https://create-react-app.dev/), האפליקציה שלכם יושבת ב`src/App.js`. כתלות בקונפיגורציה שלכם, קומפוננטת השורש יכולה לשבת בקובץ אחר. אם אתם משתמשים בפריימוורק עם ראוטינג שמתבסס על מבנה הקבצים, כמו למשל Next.js, קומפוננטת השורש שלכם תהיה שונה עבור כל עמוד. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root*
|
||
What if you want to change the landing screen in the future and put a list of science books there? Or place all the profiles somewhere else? It makes sense to move `Gallery` and `Profile` out of the root component file. This will make them more modular and reusable in other files. You can move a component in three steps: | ||
מה אם תרצו לשנות את דף הנחיתה בעתיד, ולשים שם רשימה של ספרי מדע? או להשתמש בפרופילים במקום אחר באפליקציה? צעד סביר יהיה להזיז את קומפוננטות: `Gallery` ו-`Profile` מחוץ לקומפוננטת השורש שלכם. צעד זה יהפוך אותם ליותר מודולריים וריוזביליים בקבצים אחרים. ניתן להזיז קומפוננטה בשלושה צעדים: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root
reusable במקום ריוזבלים
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review :/
I stopped halfway because there is a repeating pattern we did in the first version that I was hoping we could ditch in the new version - translating every word to Hebrew
We should not translate words and phrases to קומפוננטת שורש, and לקנן and ייצוא שמי.
It doesn't sound right and most people will get confused, also in our work places we don't say ייצוא שמי and לקנן, we say in English what sounds not right in Hebrew
any chance we can have a quick conversation on zoom or some other platform? |
We should have the discussion here so other contributors can use this as a reference in the future |
Great idea, Im having trouble with markdown and ltr-rtl of hebrew and english mixed sentences, any advice for this? |
I haven't found a text editor that can handle that, I'm using the Notes app on Mac to translate, then I replace the English sentence with the translated one. Not a great solution but it works |
I'm redoing the translation from the beginning. one issue that's bugging me is, i'm running the project locally so i can see my changes, but all of the content is ltr instead of rtl. is this something that still needs setting up? is it something i can do? |
i'm closing this pr, as i opened a new branch with the updated docs file structure, when i'm ready i will open a new pr. |
Assigned to me in issue: #280