Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate You Might Not Need An Effect #362

Closed
wants to merge 6 commits into from

Conversation

averrows
Copy link

@averrows averrows commented Apr 27, 2023

Bahasa translation for Escape Hatches > You might not need an effect.

Issue: #330

Closes #390

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some discussions and suggestions to consider.

src/content/learn/escape-hatches.md Outdated Show resolved Hide resolved
src/content/learn/escape-hatches.md Outdated Show resolved Hide resolved
src/content/learn/escape-hatches.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to avoid translating the variable and function names.

cc @resir014 @r17x @mazipan @zainfathoni

src/content/learn/escape-hatches.md Outdated Show resolved Hide resolved
src/content/learn/escape-hatches.md Outdated Show resolved Hide resolved
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

1 similar comment
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@reactjs reactjs deleted a comment from vercel bot Apr 28, 2023
@mhaidarhanif mhaidarhanif marked this pull request as draft April 28, 2023 15:12
@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Apr 28, 2023

@averrows Converted back to draft because starting from "Lifecycle of reactive effects" it's not been translated yet.

@resir014
Copy link
Member

@averrows Hello, any progress on the remaining untranslated content? If we don't hear from you within 24-48 hours, we're going to reassign this PR to someone else.

@resir014 resir014 changed the title New Indonesian Translation: Escape Hatches > You might not need an effect docs: translate You Might Not Need An Effect Jun 13, 2023
@averrows
Copy link
Author

Hi @resir014, per my understanding, "Lifecycle of reactive effects" and parts after that are on different issues ex: #391. And my translation of "You Might Not Need an Effect" is all done and I had applied the reviews. Or do I understand it wrong?

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Jun 14, 2023

Wait, that's why it's confusing because it should not translate only one section of the page. All translation PRs need to translate one whole page.

@averrows This connected PR should translate the whole page of "You Might Not Need an Effect": https://id.react.dev/learn/you-might-not-need-an-effect

That issue is for that whole page. My recommendation would be fixing this by translating the intended page of "You Might Not Need an Effect", not the "Escape hatches" because it's been translated here: #522

So there's actually a misunderstanding of translating the page.

Check again from the issue list:

image

Check again from the initial issue and link to the page:

image

cc @resir014 @mazipan @zainfathoni @r17x

@resir014
Copy link
Member

Yes, as @mhaidarhanif mentioned above. If you're unable to do it, then we can reassign this PR to someone else. @averrows

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You Might Not Need an Effect
5 participants