-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: translate You Might Not Need An Effect #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some discussions and suggestions to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to avoid translating the variable and function names.
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 similar comment
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
@averrows Converted back to draft because starting from "Lifecycle of reactive effects" it's not been translated yet. |
@averrows Hello, any progress on the remaining untranslated content? If we don't hear from you within 24-48 hours, we're going to reassign this PR to someone else. |
Wait, that's why it's confusing because it should not translate only one section of the page. All translation PRs need to translate one whole page. @averrows This connected PR should translate the whole page of "You Might Not Need an Effect": https://id.react.dev/learn/you-might-not-need-an-effect That issue is for that whole page. My recommendation would be fixing this by translating the intended page of "You Might Not Need an Effect", not the "Escape hatches" because it's been translated here: #522 So there's actually a misunderstanding of translating the page. Check again from the issue list: Check again from the initial issue and link to the page: |
Yes, as @mhaidarhanif mentioned above. If you're unable to do it, then we can reassign this PR to someone else. @averrows |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Bahasa translation for
Escape Hatches > You might not need an effect
.Issue: #330
Closes #390