This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
Doughnut Chart with Text Inside #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e DoughnutWithTextInside component
Label size
updating
looking into animation fix
modifying core.js
Revert "testing"
updating the draw function
updating draw function's apply call
Removing old segments on update.
|
Thank you for this! Would you mind rebasing this? I can't merge as-is due to all the chaff
|
…e DoughnutWithTextInside component
|
Rebased. Booted up and tested our fork, everything worked as expected. Let me know what you think! Malachi |
|
Any chance we can get this merged in ? Would love to use this chart ! |
|
@Malachi-M this PR needs to be rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fork from @lemonCMS's doughtTextInside fork that allows custom text size.
Changes include:
labelScale