Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tictactoe #102

Merged
merged 6 commits into from
Nov 24, 2024
Merged

Tictactoe #102

merged 6 commits into from
Nov 24, 2024

Conversation

lxmarinkovic
Copy link
Collaborator

@lxmarinkovic lxmarinkovic commented Nov 24, 2024

No description provided.

@lxmarinkovic
Copy link
Collaborator Author

#70

@lxmarinkovic lxmarinkovic merged commit 16c1ab4 into reactjs:main Nov 24, 2024
3 checks passed
@lxmarinkovic lxmarinkovic deleted the tictactoe branch November 24, 2024 21:08
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@rammba rammba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lxmarinkovic, first of all thanks for this awesome contribution. 🚀 You've made a great job translating this oversized file, probably the biggest in the whole documentation. I can just imagine how much time it would take. ⌚

I've added bunch of comments, but most of them are some small typos or better terms than those you used. You really did an awesome thing, regardless of that.

I just want to ask you not to merge future PRs without someone's approval, not because your translation doesn't fit, but because two pair of eyes are always better than one.

Thanks for this once more, you can address comments in another PR or we can go through them together if you think something is off. I also spent quite some time on reviewing, so maybe I missed something as well. 😄

src/content/learn/tutorial-tic-tac-toe.md Show resolved Hide resolved
} else {
status = 'Next player: ' + (xIsNext ? 'X' : 'O');
status = 'Sledeći igrač : ' + (xIsNext ? 'X' : 'O');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary space before colon


We recommend that you check out the tic-tac-toe game above before continuing with the tutorial. One of the features that you'll notice is that there is a numbered list to the right of the game's board. This list gives you a history of all of the moves that have occurred in the game, and it is updated as the game progresses.
Preporučujemo vam da se prvo poigrate sa završenom igrom pre nego što nastavite sa tutorijalom. Jedna od funkcionalnosti koju ćete primetiti je numerisana lista sa desne strane table igre. Ova lista vam pruža istoriju svih poteza koji su se odigrali tokom igre, i update-je se kako igra napreduje.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jedna od funkcionalnosti koju ćete primetiti je numerisana lista sa desne strane table igre. => Jedna od funkcionalnosti koju ćete primetiti je numerisana lista sa desne strane table.

src/content/learn/tutorial-tic-tac-toe.md Show resolved Hide resolved

In the live code editor below, click **Fork** in the top-right corner to open the editor in a new tab using the website CodeSandbox. CodeSandbox lets you write code in your browser and preview how your users will see the app you've created. The new tab should display an empty square and the starter code for this tutorial.
U live code editor ispod, kliknite na ***Fork*** u gornjem desnom uglu kako bi otvorili editor u novom tabu koristeći CodeSandbox. CodeSandbox vam omogućava da pišete kod direktno u browseru i pregledate kako će aplikacija izgledati korisnicima. Novi tab bi trebalo da prikaže prazan kvadrat i početni kod za ovaj tutorijal.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U live code editor ispod => U live code editor-u ispod

@@ -2476,7 +2486,7 @@ body {

</Sandpack>

Before you can implement `jumpTo`, you need the `Game` component to keep track of which step the user is currently viewing. To do this, define a new state variable called `currentMove`, defaulting to `0`:
Pre nego što implementirate `jumpTo`, potrebno je da component-a `Game` prati koji korak korisnik trenutno gleda. Da biste to uradili, definišite novu state varijablu pod nazivom `currentMove`, sa podrazumevanom vrednošću `0`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

varijablu => promenljivu

src/content/learn/tutorial-tic-tac-toe.md Show resolved Hide resolved
- Indicates when a player has won the game,
- Stores a game's history as a game progresses,
- Allows players to review a game's history and see previous versions of a game's board.
- Omogućava igranje iks-oks,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omogućava igranje iks-oks => Omogućava igranje iks-oks igre

- Stores a game's history as a game progresses,
- Allows players to review a game's history and see previous versions of a game's board.
- Omogućava igranje iks-oks,
- Indikuje kada je igrač pobedio u igri,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indikuje => Označava

1. When someone wins, highlight the three squares that caused the win (and when no one wins, display a message about the result being a draw).
1. Display the location for each move in the format (row, col) in the move history list.
1. Samo za trenutni potez prikažite poruku "Nalazite se na potezu #..." umesto dugmeta.
2. Prepišite component-u `Board` da koristi dve petlje za kreiranje kvadrata umesto da ih hardkodirate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardkodirate => hardcode-ujete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants