Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve existing translations #74

Merged
merged 9 commits into from
Sep 17, 2024

Conversation

rammba
Copy link
Collaborator

@rammba rammba commented Sep 16, 2024

Hi, I've read all currently translated files and made some small changes, mostly typo fixes.


<Sandpack>

```js
export default function TodoList() {
const ime = 'Gregorio Y. Zara';
const name = 'Gregorio Y. Zara';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we left initial code on all other places, except translating comments, I've used english variable names here as well.

Copy link
Collaborator

@lxmarinkovic lxmarinkovic Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that things like variable names should be translated; maybe naziv would be better than Ime.
Nevertheless, I will merge your current corrections, and we can discuss this topic later :D
Btw we have a discord group chat where we can talk about this and other ideas:
https://discord.gg/KCaP5Q3B

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please traverse through your changes before I merge them, as I noticed translations of open source and a few more. Please do the check again, fix this kind of detail, and push it again :D

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@lxmarinkovic lxmarinkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg but need some minor corrections :D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, "dobrodosli" as an adjective is correct, but as a greeting, you are on the spot; it should be "dobro dosli." I think this is a good starting point for you before diving into translating more of the content to correct things like the one from above or adding hyphens, etc.
Thanks for your time and effort! :D

Copy link
Collaborator

@lxmarinkovic lxmarinkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rammba 🚀

@lxmarinkovic lxmarinkovic merged commit eb5f04d into main Sep 17, 2024
3 checks passed
@lxmarinkovic lxmarinkovic deleted the features/improve-existing-translations branch September 17, 2024 12:55
@lxmarinkovic
Copy link
Collaborator

lxmarinkovic commented Sep 17, 2024

Thanks for your excellent work @rammba . Don't forget to join our discord group chat https://discord.gg/KCaP5Q3B 🖖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants