Add HTTP/2 PING-based connection health checks
#3980
Merged
+1,562
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce PING frame support for proactive connection health monitoring on idle HTTP/2 connections. The feature sends PING frames to detect unresponsive peers and close stale connections. Configuration via Http2SettingsSpec: - pingAckTimeout: Timeout for ACK response - pingAckDropThreshold: Maximum PING attempts (default: 1) Requires idle timeout configuration: - Client: ConnectionProvider.maxIdleTime - Server: HttpServer.idleTimeout The feature is opt-in and integrates automatically with connection pool eviction (client) and idle timeout handling (server). This implementation is based on PR #3612, reduces the scope and adds HttpClient support. Co-authored-by: raccoonback <[email protected]> Signed-off-by: Violeta Georgieva <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...les/src/main/java/reactor/netty/examples/documentation/http/server/liveness/Application.java
Dismissed
Show dismissed
Hide dismissed
reactor-netty-http/src/test/java/reactor/netty/http/Http2ConnectionLivenessTest.java
Dismissed
Show dismissed
Hide dismissed
reactor-netty-http/src/test/java/reactor/netty/http/Http2ConnectionLivenessTest.java
Dismissed
Show dismissed
Hide dismissed
reactor-netty-http/src/test/java/reactor/netty/http/Http2ConnectionLivenessTest.java
Dismissed
Show dismissed
Hide dismissed
reactor-netty-http/src/test/java/reactor/netty/http/Http2ConnectionLivenessTest.java
Dismissed
Show dismissed
Hide dismissed
reactor-netty-http/src/test/java/reactor/netty/http/server/HttpIdleTimeoutTest.java
Dismissed
Show dismissed
Hide dismissed
reactor-netty-http/src/test/java/reactor/netty/http/server/HttpIdleTimeoutTest.java
Dismissed
Show dismissed
Hide dismissed
reactor-netty-http/src/test/java/reactor/netty/http/server/HttpIdleTimeoutTest.java
Dismissed
Show dismissed
Hide dismissed
reactor-netty-http/src/test/java/reactor/netty/http/server/HttpIdleTimeoutTest.java
Dismissed
Show dismissed
Hide dismissed
Signed-off-by: Violeta Georgieva <[email protected]>
Signed-off-by: Violeta Georgieva <[email protected]>
Signed-off-by: Violeta Georgieva <[email protected]>
Signed-off-by: Violeta Georgieva <[email protected]>
Signed-off-by: Violeta Georgieva <[email protected]>
|
@violetagg |
raccoonback
reviewed
Nov 3, 2025
There was a problem hiding this comment.
@violetagg
I added some comments with a few questions.
I’d appreciate it if you could review them.
reactor-netty-http/src/main/java/reactor/netty/http/Http2ConnectionLiveness.java
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/Http2ConnectionLiveness.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public void operationComplete(ChannelFuture future) { | ||
| if (!future.channel().isActive()) { |
There was a problem hiding this comment.
Since the future will be newly created, would it be fine not to check the active state of the current context channel?
(ex. !ctx.channel().isActive())
There was a problem hiding this comment.
Can you elaborate more?
reactor-netty-http/src/main/java/reactor/netty/http/client/Http2ConnectionProvider.java
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/Http2ConnectionProvider.java
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/Http2ConnectionProvider.java
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/Http2ConnectionProvider.java
Show resolved
Hide resolved
|
@raccoonback Thanks for the review! Let me merge this one. |
violetagg
added a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
PINGframe support for proactive connection health monitoring on idleHTTP/2connections. The feature sendsPINGframes to detect unresponsive peers and close stale connections.Configuration via
Http2SettingsSpec:pingAckTimeout: Timeout forACKresponsepingAckDropThreshold: MaximumPINGattempts (default: 1)Requires idle timeout configuration:
ConnectionProvider.maxIdleTimeHttpServer.idleTimeoutThe feature is opt-in and integrates automatically with connection pool eviction (client) and idle timeout handling (server).
This implementation is based on PR #3612, reduces the scope and adds
HttpClientsupport.