Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Lit Context to share config across all addons #491

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 13, 2025

@humitos humitos force-pushed the humitos/lit-context-config branch from 952d5d5 to 2289537 Compare January 13, 2025 15:23
@humitos
Copy link
Member Author

humitos commented Jan 13, 2025

I merged #455 into this PR to give it a try, and I was able to re-display a notification by clicking on the "Change URL" button 🎉 . It seems this Lit Context pattern is proving that's going to work for what we want to do 👍🏼 .

There is going to be some updates we will need to do to our addons, tho. Example: I found that this.autoDismissed reactive property won't work immediately because the render() method returns nothing immediately if it was auto dismissed. That particular example might not be an issue, but it's something to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant