Add discounts to the dashboard #795
Merged
+74
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The discounts come in the form of Stripe coupons. The description can be edited in Stripe. Currently, we have just a 10% and 15% coupon based on the total campaign size. They appear in: - The create/edit flight screens (for staff). The discounts are not automatically applied yet. When a flight is renewed, the discount is renewed by default. - They appear in the memo section of invoices - They are displayed in the flight metadata to advertisers
ericholscher
approved these changes
Oct 11, 2023
| @@ -670,14 +670,14 @@ def action_create_draft_invoice(self, request, queryset): | |||
| ) | |||
|
|
|||
| # https://stripe.com/docs/api/invoices/create | |||
| description = "Thanks for your business!" | |||
There was a problem hiding this comment.
Ha, I never noticed this before :)
There was a problem hiding this comment.
I usually fill out the memo line to reference a PO or if this is "invoice 1 of 3", etc.
Correct. The pricing doesn't change at all. I did remove the weird logic we had where flights where priced per view if the number of views was not divisible by 1000 and CPM otherwise. It's always per view or click now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discounts come in the form of Stripe coupons. The description can be edited in Stripe. Currently, we have just a 10% and 15% coupon based on the total campaign size.
They appear in:
Screenshot