Initial work for day of the week targeting #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly just wanted initial feedback here before I finish this work up. Does this approach look reasonable? The other approach I considered was having `days` be either `weekdays` or `weekends`, which might be cleaner, but thought the flexibility was more useful of having specific days.
davidfischer
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
The other approach I considered was having days be either weekdays or weekends,
which might be cleaner, but thought the flexibility was more useful of having specific days.
I think this is fine and I could conceivably see advertisers skipping Fridays or Mondays or something like that.
| @@ -292,6 +293,10 @@ def filter_flight(self, flight): | |||
| if flight.weighted_clicks_needed_this_interval() <= 0: | |||
| return False | |||
|
|
|||
| # Skip if the flight is not meant to show on these days | |||
| if not flight.show_to_day(timezone.now().strftime("%A").lower()): | |||
There was a problem hiding this comment.
I guess locale will always be EN_US so this should just work.
There was a problem hiding this comment.
Ah, good point. You can also get it to return an int, and use that to map to the day, if we're worried about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just wanted initial feedback here before I finish this work up.
Does this approach look reasonable?
The other approach I considered was having
daysbe eitherweekdaysorweekends,which might be cleaner, but thought the flexibility was more useful of having specific days.