Allow swapping ST models #863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfischer
approved these changes
Apr 10, 2024
This is a WIP PR that allows us to define the model in the env.
ericholscher
force-pushed
the
swap-model
branch
from
5e0b859 to
a605c5e
Compare
davidfischer
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
This model looks like it gives a good blend of performance and speed. Have you tested it against our stuff to get a general opinion of how it performs?
Which model? There's three there, and we're using the smallest one. We could always try with one of the larger ones. But in general, they're all gonna perform much worse than any of the frontier models I'd expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR that allows us to define the model in the env.