Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roles for advertisers and publishers #941

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

davidfischer
Copy link
Collaborator

  • Add 3 permission levels for advertisers and publishers
  • The migration will default everybody to the highest permission
  • Role permissions are checked in the UI and in the backend
  • Admin users can change publisher settings, and invite users.
  • Managers can edit things
  • Reporters can't change anything.

Screenshot

Screenshot from 2024-11-14 16-18-07

- Add 3 permission levels for advertisers and publishers
- The migration will default everybody to the highest permission
- Role permissions are checked in the UI and in the backend
- Admin users can change publisher settings, and invite users.
- Managers can edit things
- Reporters can't change anything.
@davidfischer davidfischer requested a review from a team as a code owner November 15, 2024 00:18
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great. Just had a couple questions on the template tags and not using too many constants, but overall looks solid.

adserver/auth/models.py Show resolved Hide resolved
adserver/tests/test_advertiser_dashboard.py Outdated Show resolved Hide resolved
adserver/views.py Show resolved Hide resolved
@davidfischer davidfischer merged commit 2c8c38b into main Nov 20, 2024
1 check passed
@davidfischer davidfischer deleted the davidfischer/roles-advertisers-publishers branch November 20, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants