Addons: return all active versions on single version project #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always return all the active versions no matter the versioning scheme of the project. That's how `versions.active` is expected to work. However, it seems the conditional was below where these versions are calculated. I also updated the test case that checks for the active versions on single versions projects. Closes readthedocs/sphinx_rtd_theme#1613
stsewd
reviewed
Oct 30, 2024
There was a problem hiding this comment.
We should have a special case for single version projects. I don't think we have any type of validation when a project is single version project, and users can still activate versions, or when a multi version projects switches to single version. Those versions will still be marked as active, but even if they are built, users won't be able to see them (since our serving code does validate for that).
stsewd
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always return all the active versions no matter the versioning scheme of the project. That's how
versions.activeis expected to work.However, it seems the conditional was below where these versions are calculated. I also updated the test case that checks for the active versions on single versions projects.
Closes readthedocs/sphinx_rtd_theme#1613