Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run FileTreeDiff indexer on all versions in dev #11873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ericholscher
Copy link
Member

This allows easier support for working on this locally,
and runs it against all active verisons.

This allows easier support for working on this locally,
and runs it against all active verisons.
@ericholscher ericholscher requested a review from a team as a code owner December 24, 2024 01:01
@ericholscher ericholscher requested a review from humitos December 24, 2024 01:01
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if we don't have different behavior for these on development than in production. It gets hard to debug when something doesn't work as expected.

It's useful to have to file the full workflow in development as well, so we know how it works on production as well.

@ericholscher
Copy link
Member Author

@humitos it seems really hard to setup GH webhooks and full integration locally, including having a "local" instance pushing live build status to PRs, so I think it makes sense here?

@humitos
Copy link
Member

humitos commented Jan 7, 2025

That's a good point. I forgot how I was testing this, but definitely not setting up GH webhooks nor pushing live build status to PRs. I think I marked a Version.is_external=True from the Django admin 🤔

@ericholscher
Copy link
Member Author

Yea, just seems nice to have a good way to turn this on locally. You still need to enable it in the Addons Config, but I think having a good test of it is useful, and makes dev easier. But I can also just do a quick note in the docs/code about a workflow for enabling dev if we think that's better than baking it into the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants