-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Addons customization docs #11888
base: main
Are you sure you want to change the base?
Conversation
This is start for this work, and mostly just pulls examples from the Mkdocs page over to the Addons docs. I think there's more to do here with examples, but I think this is a reasonable starting point.
I would not document the CSS variables yet since we are having a discussion about that in readthedocs/addons#473 and we are thinking about removing support for them for now while we explore how to it in a reliable way. |
This reverts commit 755bfff.
This reverts commit a371da0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There are a few pending decisions we may want to decide before merging; but other than that, looks like a good first step.
|
||
:root { | ||
/* Reduce Read the Docs' flyout font a little bit */ | ||
--readthedocs-flyout-font-size: 0.7rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment about if users should use rem
or px
here in readthedocs/addons#488 (comment) because it's not 100% clear to me yet.
- ``--readthedocs-search-result-section-highlight-color`` | ||
- ``--readthedocs-search-result-section-subheading-color`` | ||
|
||
You can find default values and full CSS in our `Addons source <https://github.com/readthedocs/addons/tree/main/src>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a .. tip::
block.
- ``--readthedocs-flyout-dd-font-size`` | ||
- ``--readthedocs-flyout-dt-font-size`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agjohnson mentioned these dd-
where not necessary in readthedocs/addons#488 (comment), so I'm not sure if he is planning to remove them.
* ``projects.current`` - Current project details | ||
* ``projects.translations`` - Available translations | ||
* ``versions.current`` - Details about the current version | ||
* ``versions.active`` - List of all active versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the list of "active, built and not hidden" versions. We can explain that in the paragraph.
} | ||
} | ||
|
||
You can see a live example of this in our `Addons API response for these docs <https://docs.readthedocs.io/_/addons/?client-version=0.22.0&api-version=1&project-slug=docs&version-slug=stable>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also be a .. tip::
This is start for this work,
and mostly just pulls examples from the Mkdocs page over to the Addons docs.
I think there's more to do here with examples,
but I think this is a reasonable starting point.
📚 Documentation previews 📚
docs
): https://docs--11888.org.readthedocs.build/en/11888/dev
): https://dev--11888.org.readthedocs.build/en/11888/