Skip to content

Repo sync: use project queue for syncing #12529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
Merged

Repo sync: use project queue for syncing #12529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27a8fe8
Repo sync: use project queue for syncing
stsewd Oct 21, 2025
78ec180
Merge branch 'main' into use-project-queue-for-syncing
stsewd Oct 28, 2025
a6f211e
Fix test
stsewd Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions readthedocs/core/views/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,17 @@ def trigger_sync_versions(project):
project_slug=version.project.slug,
version_slug=version.slug,
)

options = {}
# Use custom queue if defined, as some repositories need to
# be synced from a specific queue (like IP restricted ones).
if project.build_queue:
options["queue"] = project.build_queue

sync_repository_task.apply_async(
args=[version.pk],
kwargs={"build_api_key": build_api_key},
**options,
)
return version.slug
except Exception:
Expand Down
4 changes: 2 additions & 2 deletions readthedocs/rtd_tests/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2032,7 +2032,7 @@ def test_sync_repository_custom_project_queue(
self, sync_repository_task, trigger_build
):
"""
Check that the custom queue isn't used for sync_repository_task.
Check that the custom queue is used for sync_repository_task.
"""
client = APIClient()
self.project.build_queue = "specific-build-queue"
Expand Down Expand Up @@ -2064,7 +2064,7 @@ def test_sync_repository_custom_project_queue(
kwargs={
"build_api_key": mock.ANY,
},
# No queue
queue="specific-build-queue",
)

def test_github_webhook_for_branches(self, trigger_build):
Expand Down