-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention "Hosted on Read the Docs" in the footer #1616
base: master
Are you sure you want to change the base?
Conversation
Not sure if I understand the need for this link from the underlying issue, but it feels a bit redundant or maybe even spammy. Is there a reason we need a second link to us? |
We don't need a second link. I removed the old one in 14d07f9 |
To clarify, it's not just the link, it's the text that feels redundant/spammy. This will still render as:
This still feels redundant, maybe spammy -- it doesn't feel to me like we need our name in there twice on every page.
That seems fine. I'm also fine not mentioning hosting. I think it's a surprise to users when there is conditional content like this -- locally this string isn't there but our builds produce different output. |
{% endif %} | ||
|
||
{% if READTHEDOCS %} | ||
Hosted on <a href="https://about.readthedocs.com/">Read the Docs</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be wrapped by show_sphinx
or a specific configuration option. If the user selected show_sphinx = False
, they will probably not like that we injected different content in the same space.
Closes #1587