Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
danielPeloton committed Aug 29, 2023
1 parent f03d95e commit c1c68d8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,3 @@ private extension NSLocalizedStringRequireBundleRule {
}
}

private extension TupleExprElementListSyntax {
func containsArgument(named name: String) -> Bool {
contains { arg in
arg.label?.tokenKind == .identifier(name)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ struct UIImageIncludesBundleRule: SwiftSyntaxRule, OptInRule, ConfigurationProvi
static let description = RuleDescription(
identifier: "uiimage_requires_bundle",
name: "UIImage Requires Bundle",
description: "`UIImage(named:) must specify a bundle via the `in:` parameter",
description: "`UIImage(named:)` must specify a bundle via the `in:` parameter",
kind: .lint,
nonTriggeringExamples: [
Example("""
Expand Down Expand Up @@ -90,11 +90,3 @@ private extension UIImageIncludesBundleRule {
}
}
}

private extension TupleExprElementListSyntax {
func containsArgument(named name: String) -> Bool {
contains { arg in
arg.label?.tokenKind == .identifier(name)
}
}
}
8 changes: 8 additions & 0 deletions Source/SwiftLintCore/Extensions/SwiftSyntax+SwiftLint.swift
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,14 @@ public extension AccessorBlockSyntax {
}
}

public extension TupleExprElementListSyntax {
func containsArgument(named name: String) -> Bool {
contains { arg in
arg.label?.tokenKind == .identifier(name)
}
}
}

public extension TypeInheritanceClauseSyntax? {
func containsInheritedType(inheritedTypes: Set<String>) -> Bool {
self?.inheritedTypeCollection.contains { elem in
Expand Down

0 comments on commit c1c68d8

Please sign in to comment.