-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make implicitly confirming to Actor to trigger warning #5465
Closed
marunomi
wants to merge
4
commits into
realm:main
from
marunomi:implicitly_inhelited_actor_on_missing_docs
Closed
Make implicitly confirming to Actor to trigger warning #5465
marunomi
wants to merge
4
commits into
realm:main
from
marunomi:implicitly_inhelited_actor_on_missing_docs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresluis1
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve #5422 by adding checking for implicitly confirming to Actor protocol.
Before the validate function, I used visitPost(_ node: ActorDeclSyntax) to determine if the actor keyword is used.
I wrote it this way because I could not determine within the missingDocOffsets function whether the actor keyword is used or not.