-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace TestAppSession close()/reopen() with scope based TestAppSession instance #7672
Open
michael-wb
wants to merge
19
commits into
master
Choose a base branch
from
mwb/fix-test-app-session
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+143
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build michael.wilkersonbarker_1168Details
💛 - Coveralls |
michael-wb
changed the title
Update TestAppSession to take a config object and be restarted
Replace TestAppSession close()/reopen() with scope based TestAppSession instance
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The
TestAppSession
object for tracking an App/SyncManager and an AppSession was updated in PR #7528 to allow the App instance to be restarted without recreating or logging in a user to allow testing the situation where a SyncSession with a cached user tries to communicate with the server before updating the location. It was recommended in that PR's review comments to update the TestAppSessionclose()
andreopen()
functions with more of a scope-based close and open mechanism.This PR updates this object to remove the
close()
/reopen()
functions and adds aConfig
structure that is passed to theTestAppSession
for configuring the app session.☑️ ToDos
[ ] C-API, if public C++ API changed[ ]bindgen/spec.yml
, if public C++ API changed