RCORE-2064 String EQ/NEQ optimisations for compressed strings

[nicola-cab]

What, How & Why?

Optimize query/search with EQ/NE

String translation to StringID (interned string ID) is currently done for each array search. This PR is to move the translation up the call chain, such that it is done only once for a column.

Note: Even if a string has not been interned, it may still be present in leaf arrays which have not been interned (interned and non-interned leafs may coexist within a column)

[coveralls-official]

Pull Request Test Coverage Report for Build nicola.cabiddu_1798

Details

• 41 of 41 (100.0%) changed or added relevant lines in 4 files are covered.
• 115 unchanged lines in 11 files lost coverage.
• Overall coverage decreased (-0.04%) to 90.818%

---

Files with Coverage Reduction	New Missed Lines	%
src/realm/array_with_find.hpp	2	98.15%
src/realm/sync/network/http.hpp	2	82.27%
src/realm/query_expression.hpp	3	93.84%
src/realm/sync/client.cpp	3	91.78%
test/fuzz_tester.hpp	4	57.32%
test/object-store/util/sync/baas_admin_api.cpp	5	84.93%
src/realm/sync/noinst/protocol_codec.hpp	6	73.5%
src/realm/sync/noinst/server/server.cpp	8	74.11%
src/realm/sync/instruction_applier.cpp	12	68.01%
src/realm/sync/noinst/client_impl_base.cpp	18	82.02%

Totals
Change from base Build nicola.cabiddu_1796:	-0.04%
Covered Lines:	218024
Relevant Lines:	240067

---

💛 - Coveralls

[coveralls-official]

Pull Request Test Coverage Report for Build nicola.cabiddu_1804

Details

• 48 of 48 (100.0%) changed or added relevant lines in 4 files are covered.
• 101 unchanged lines in 18 files lost coverage.
• Overall coverage decreased (-0.01%) to 90.846%

---

Files with Coverage Reduction	New Missed Lines	%
src/realm/array_string.cpp	1	88.13%
src/realm/sync/noinst/server/server_history.cpp	1	63.7%
src/realm/array_blobs_big.cpp	2	98.58%
src/realm/array_with_find.hpp	2	98.15%
src/realm/db.cpp	2	92.06%
src/realm/sync/network/http.hpp	2	82.76%
src/realm/sync/noinst/server/server.cpp	2	74.26%
test/object-store/sync/flx_sync.cpp	2	98.22%
test/object-store/util/test_file.cpp	2	86.29%
src/realm/unicode.cpp	3	83.83%

Totals
Change from base Build nicola.cabiddu_1801:	-0.01%
Covered Lines:	218304
Relevant Lines:	240302

---

💛 - Coveralls

[nicola-cab]

@jedelbo should be ready for a second pass... Much smaller :)

[coveralls-official]

Pull Request Test Coverage Report for Build nicola.cabiddu_1822

Details

• 16 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
• 1693 unchanged lines in 70 files lost coverage.
• Overall coverage decreased (-0.003%) to 90.859%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/realm/array_string.cpp	7	8	87.5%

Files with Coverage Reduction	New Missed Lines	%
src/realm/chunked_binary.cpp	1	98.36%
src/realm/sync/noinst/server/server_history.cpp	1	63.7%
src/realm/table.cpp	1	90.1%
test/object-store/sync/session/connection_change_notifications.cpp	1	93.88%
test/util/crypt_key.cpp	1	75.0%
src/realm/array_blobs_big.cpp	2	98.58%
src/realm/array_key.cpp	2	96.55%
src/realm/db.hpp	2	87.63%
src/realm/query_expression.cpp	2	86.62%
test/test_lang_bind_helper.cpp	2	93.2%

Totals
Change from base Build nicola.cabiddu_1821:	-0.003%
Covered Lines:	218312
Relevant Lines:	240275

---

💛 - Coveralls

[jedelbo]

I think the fixes took the wrong turn. The PR is about looking up the search string once and use that.