Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNET-1159: Flexible-schema POC #3630

Draft
wants to merge 55 commits into
base: fp/flexible-schema-epic
Choose a base branch
from

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Jun 18, 2024

This PR is a POC for the flexible schema

Fixes #3629

@cla-bot cla-bot bot added the cla: yes label Jun 18, 2024
@papafe papafe changed the title Flexible-schema POC RNET-1159: Flexible-schema POC Jun 18, 2024
Copy link

coveralls-official bot commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9562073620

Details

  • 81 of 85 (95.29%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 81.288%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Dynamic/DynamicObjectApi.cs 30 31 96.77%
Realm/Realm/DatabaseTypes/Accessors/ManagedAccessor.cs 0 3 0.0%
Totals Coverage Status
Change from base Build 9508907428: 0.03%
Covered Lines: 6847
Relevant Lines: 8281

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9594792417

Details

  • 108 of 114 (94.74%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 81.251%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Dynamic/DynamicObjectApi.cs 34 35 97.14%
Realm/Realm/Handles/ObjectHandle.cs 66 71 92.96%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Handles/ObjectHandle.cs 1 91.67%
Totals Coverage Status
Change from base Build 9508907428: -0.01%
Covered Lines: 6873
Relevant Lines: 8310

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9641053688

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 108 of 114 (94.74%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 81.251%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Dynamic/DynamicObjectApi.cs 34 35 97.14%
Realm/Realm/Handles/ObjectHandle.cs 66 71 92.96%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Handles/ObjectHandle.cs 1 91.67%
Totals Coverage Status
Change from base Build 9508907428: -0.01%
Covered Lines: 6873
Relevant Lines: 8310

💛 - Coveralls

@papafe papafe changed the base branch from main to fp/flexible-schema-epic July 25, 2024 14:01
@papafe papafe added the no-changelog Used to skip the changelog check label Jul 26, 2024
Copy link

coveralls-official bot commented Jul 26, 2024

Pull Request Test Coverage Report for Build 10300795369

Details

  • 210 of 229 (91.7%) changed or added relevant lines in 9 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 81.548%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Schema/ObjectSchema.cs 27 28 96.43%
Realm/Realm/Realm.cs 9 11 81.82%
Realm/Realm/Schema/Property.cs 11 15 73.33%
Realm/Realm/Dynamic/DynamicObjectApi.cs 45 51 88.24%
Realm/Realm/Handles/ObjectHandle.cs 104 110 94.55%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Sync/Session.cs 1 90.63%
Realm/Realm/Realm.cs 2 92.95%
Realm/Realm/Handles/SessionHandle.cs 3 83.48%
Totals Coverage Status
Change from base Build 10042303809: 0.05%
Covered Lines: 7015
Relevant Lines: 8443

💛 - Coveralls

@papafe papafe requested review from nirinchev and elle-j July 26, 2024 17:34
@papafe
Copy link
Contributor Author

papafe commented Jul 26, 2024

@nirinchev @elle-j This is not complete, but I thought it would be good to have an initial feedback.
What I think it's missing:

  • Try to reduce the internal API methods
  • Retrieve the complete schema from realm (not only the model and extra properties)
  • Tests for queries/keypath/notifications (these requires the core implementation too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flexible schema POC
1 participant