Adding types for passing objects when constructing objects #6675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This adds types to allow passing object links and embedded objects when creating objects using a class-based model constructor:
Unfortunately, the
RequiredProperties
passed as type parameter ("street" | "city"
) when declaringAddress
doesn't cascade as expected, which is whyalice
can be created without passingcity
. As an alternativeRealmObjectRemappedModelPart
type could be extended to make all properties required, but I haven't been able to express the constructor type from the instance typeT[K]
in a way that I could infer theRequiredProperties
correctly.☑️ ToDos
Compatibility
label is updated or copied from previous entryCOMPATIBILITY.md
package.json
s (if updating internal packages)Breaking
label has been applied or is not necessary