-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- Fix Datetime
rounding in RLMConvertBsonToRLMBSON
#8725
base: master
Are you sure you want to change the base?
- Fix Datetime
rounding in RLMConvertBsonToRLMBSON
#8725
Conversation
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @anton-plebanovich. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@anton-plebanovich are you able to merge or do we need to summon mongodb staff..? |
I cannot merge and of course, someone from the Realm team has to review first since there might be unforeseen side effects I am unaware of. |
Realm is dead and no one at MongoDB is assigned to review PRs. Probably we need to organize around a community fork |
We are moving away from Realm Sync and are using Functions as an intermediate step. Thus, this change was needed to receive valid responses. I have created a fork for myself but this is only temporarily needed until we finish our transition so I don't want to spend more effort than needed here. |
I noticed that the
Date
types returned from Sync Functions calls are rounded to seconds. This PR fixes the issue. Please note that I am not a C++ programmer so this probably could be done in a better way. I will gladly accept any fix requests with hints.