formatting

realodix · Dec 1, 2024 · 6dd3850 · 6dd3850
1 parent c6e1feb
commit 6dd3850
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/app/Services/KeyGeneratorService.php b/app/Services/KeyGeneratorService.php
@@ -92,16 +92,17 @@ public function reservedKeyword()
     }
 
     /**
-     * Reserved keywords that are already in use as url shortened keywords.
+     * The keywords that are currently in use as active keywords, but also are
+     * reserved keywords.
      *
      * @return \Illuminate\Support\Collection
      */
     public function reservedActiveKeyword()
     {
         $reservedKeyword = $this->reservedKeyword();
-        $usedKeyWord = Url::pluck('keyword')->toArray();
+        $activeKeyword = Url::pluck('keyword')->toArray();
 
-        return $reservedKeyword->intersect($usedKeyWord);
+        return $reservedKeyword->intersect($activeKeyword);
     }
 
     /*

diff --git a/tests/Unit/Services/KeyGeneratorServiceTest.php b/tests/Unit/Services/KeyGeneratorServiceTest.php
@@ -169,15 +169,15 @@ public function testReservedActiveKeyword()
         );
 
         // Test case 2: Some reserved keywords already in use
-        $usedKeyWord = 'zzz' . fake()->word();
-        Url::factory()->create(['keyword' => $usedKeyWord]);
+        $activeKeyword = 'zzz' . fake()->word();
+        Url::factory()->create(['keyword' => $activeKeyword]);
 
-        $fileSystem->makeDirectory(public_path($usedKeyWord));
+        $fileSystem->makeDirectory(public_path($activeKeyword));
         $this->assertEquals(
-            $usedKeyWord,
+            $activeKeyword,
             $this->keyGenerator->reservedActiveKeyword()->implode(''),
         );
-        $fileSystem->deleteDirectory(public_path($usedKeyWord));
+        $fileSystem->deleteDirectory(public_path($activeKeyword));
     }
 
     /**