CHECK_AUTH should return Promise

[tecfu]

Fixes #47

[igeligel]

I would vote for a refactor into a variable. Seems much more cleaner then

[igeligel]

We can omit the else block here.

if (JwtService.getToken()) {
  // ...
  return
}

context.commit(PURGE_AUTH)
resolve()

It is called If-Guard-Clauses and is recommended by a lot of Clean Code enthusiasts.

[tecfu]

@igeligel I love that you raised this issue of early returns. I read http://blog.timoxley.com/post/47041269194/avoid-else-return-early to get a fix on the debate. Useful comments on that article.

Maybe I'm doing it wrong, but my implementation of an early return here would look like:

return new Promise((resolve, reject) => {
      const token = JwtService.getToken()
      if (!token) {
        context.commit(PURGE_AUTH)
        return resolve()
      }

      ApiService.setHeader()
      ApiService
        .get('user')
        .then(({data}) => {
          context.commit(SET_AUTH, data.user)
          resolve(data)
        })
        .catch(({response}) => {
          context.commit(SET_ERROR, response.data.errors)
          resolve()
        })
    })

Not a fan of that at all.

I think scattering the return adds complexity. The benefit of a single column of indentation really doesn't do anything for me here because we don't have nested conditionals anyway.

If anything I see this supporting the "single exit point" argument, because it would be more difficult for new eyes to debug the scattered return.

By comparison, we previously had:

return new Promise((resolve, reject) => {
      const token = JwtService.getToken()
      if (token) {
        ApiService.setHeader()
        ApiService
          .get('user')
          .then(({data}) => {
            context.commit(SET_AUTH, data.user)
            resolve(data)
          })
          .catch(({response}) => {
            context.commit(SET_ERROR, response.data.errors)
            resolve()
          })
      } else { 
        context.commit(PURGE_AUTH)
        resolve()
      }
    })

Would love to read more arguments on this.

[igeligel]

Hey, @tecfu Since I upgraded the code base to the vue-cli 3 now with this commit eeaeb34 you have some merge conflicts. You can solve them by syncing your fork locally with these commands https://help.github.com/articles/syncing-a-fork/ and then merge the master branch into your branch. You need to fix all of the merge conflicts though.