Avoid infinite loop in lexer on unclosed code block #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unclosed code block will cause the lexer to loop infinitely in the 'block' rule, because 'eof' is part of the 'eol' rule and it'll keep matching the last rule. Add a separate rule for eof that terminates immediately, the way the first rule was written it would expect closing quotes after eof which would never match eof. Signed-off-by: Edwin Török <[email protected]>
|
This should fix #420 -- We hit this in Eio whilst debugging some other issues, would be a good thing to have merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unclosed code block will cause the lexer to loop infinitely in the 'block' rule, because 'eof' is part of the 'eol' rule and it'll keep matching the last rule.
Add a separate rule for eof that terminates immediately, the way the first rule was written it would expect closing quotes after eof which would never match eof.