Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an 'exec' label to execute include OCaml blocks #450

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gpetiot
Copy link
Contributor

@gpetiot gpetiot commented Mar 4, 2024

Follow up on #446

The code of panglesd@85b9142 is already squashed, so that's a more difficult to go back in time. I couldn't re-create that behavior yet.

@panglesd if you see something weird with the exec/skip interaction for the ocaml includes I'm interested :)

@gpetiot gpetiot requested a review from panglesd March 4, 2024 17:20
@panglesd
Copy link
Collaborator

panglesd commented Mar 4, 2024

Will have a look, but we need some logic to add this to the dependencies as pointed here!

| `OCaml ->
let kind =
Util.Option.value ~default:OCaml_kind.Impl
(OCaml_kind.infer_from_file file_included)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Ocaml_kind.infer_from_file is called twice in a few lines... Maybe store the result in the `OCaml polymorphic variant?

(This would also remove the call to Option.value)

Comment on lines +32 to +33
Line 1, characters 1-7:
Error: Unbound module Pipe
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an idea why this PR is making this change? It seems wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants