-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(job_monitor): log job pod errors, disruptions to warning (#468) #468
feat(job_monitor): log job pod errors, disruptions to warning (#468) #468
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 47.04% 47.95% +0.91%
==========================================
Files 17 17
Lines 1271 1299 +28
==========================================
+ Hits 598 623 +25
- Misses 673 676 +3
|
5bd1f9f
to
59ef4d0
Compare
59ef4d0
to
561287e
Compare
561287e
to
1a4b97a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
61acfe7
to
e0f375d
Compare
e0f375d
to
891049c
Compare
891049c
to
e685b6b
Compare
e685b6b
to
db9c258
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely 👍
Squashed the doc commit to the first one and slightly rephrased the commit headlines for release news.
Related to reanahub/reana#824
Fix multiline formatting. Log pod errors, evictions and other problematic events to warning log. Cover new functionality with tests.
Example logs (with FluentBit configured to collect
job-controller
logs):OOM killed:
DeadlineExceeded:
Eviction:
Without multiline formatter it will not be possible to properly display multiline errors to REANA users using FluentBit.
Old multiline format:
New format:
With old format, FluentBit drops
line 2
andline 3
logs, so the user only seesline 1
. With new format, it saves all lines.feat(utils): add multiline log formatter (#468)
feat(job_manager): log pod errors to warning (#468)
feat(job_monitor): log pod errors, disruptions to warning (#468)