Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): make dask autoscaler configurable #702

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Alputer
Copy link
Member

@Alputer Alputer commented Sep 20, 2024

@Alputer Alputer self-assigned this Sep 20, 2024
@Alputer Alputer changed the title Dask autoscaler config feat(dask): dask autoscaler config (#702) Sep 20, 2024
Alputer added a commit to Alputer/reana-server that referenced this pull request Oct 31, 2024
@Alputer Alputer force-pushed the dask-autoscaler-config branch from 220b542 to e15970f Compare October 31, 2024 16:12
@Alputer Alputer changed the title feat(dask): dask autoscaler config (#702) feat(dask): make dask autoscaler configurable Oct 31, 2024
Alputer added a commit to Alputer/reana-server that referenced this pull request Oct 31, 2024
@Alputer Alputer force-pushed the dask-autoscaler-config branch from e15970f to 8081956 Compare October 31, 2024 16:41
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.08%. Comparing base (15d0b97) to head (95ea2df).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
reana_server/rest/info.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   60.06%   60.08%   +0.01%     
==========================================
  Files          32       32              
  Lines        3546     3550       +4     
==========================================
+ Hits         2130     2133       +3     
- Misses       1416     1417       +1     
Files with missing lines Coverage Δ
reana_server/config.py 84.15% <100.00%> (+0.17%) ⬆️
reana_server/rest/info.py 76.00% <50.00%> (-1.09%) ⬇️

Alputer added a commit to Alputer/reana-server that referenced this pull request Nov 1, 2024
@Alputer Alputer force-pushed the dask-autoscaler-config branch from 8081956 to e1f3718 Compare November 1, 2024 09:27
@@ -61,6 +61,9 @@
DASK_ENABLED = strtobool(os.getenv("DASK_ENABLED", "true"))
"""Whether Dask is enabled in the cluster or not"""

DASK_AUTOSCALER_ENABLED = strtobool(os.getenv("DASK_AUTOSCALER_ENABLED", "true"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment about "true" vs "True" in reanahub/reana-workflow-controller#604 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit log cosmetics: the conventional commit scope should represent which component was touched by the change, so we should use "config" here:

feat(config): make Dask autoscaler configurable (#835)

(Unfortunately the previous commit slipped with feat(helm) here even if this component does not have any Helm... We could override it using Release Please commit message overriding functionality to have nicer release news compilation.)

Also, please put Closes #NNN in the commit message body, so that we have the reference to the issue which this PR closes also locally, not only on GitHub.

Alputer added a commit to Alputer/reana-server that referenced this pull request Nov 11, 2024
@Alputer Alputer force-pushed the dask-autoscaler-config branch from e1f3718 to 4dbfce0 Compare November 11, 2024 09:16
@Alputer Alputer force-pushed the dask-autoscaler-config branch from 4dbfce0 to 95ea2df Compare November 11, 2024 11:30
@Alputer Alputer changed the title feat(dask): make dask autoscaler configurable feat(config): make dask autoscaler configurable Nov 11, 2024
@tiborsimko tiborsimko merged commit 95ea2df into reanahub:master Nov 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(dask): make dask autoscaler optional
2 participants