-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): make dask autoscaler configurable #702
Conversation
220b542
to
e15970f
Compare
e15970f
to
8081956
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
+ Coverage 60.06% 60.08% +0.01%
==========================================
Files 32 32
Lines 3546 3550 +4
==========================================
+ Hits 2130 2133 +3
- Misses 1416 1417 +1
|
8081956
to
e1f3718
Compare
reana_server/config.py
Outdated
@@ -61,6 +61,9 @@ | |||
DASK_ENABLED = strtobool(os.getenv("DASK_ENABLED", "true")) | |||
"""Whether Dask is enabled in the cluster or not""" | |||
|
|||
DASK_AUTOSCALER_ENABLED = strtobool(os.getenv("DASK_AUTOSCALER_ENABLED", "true")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment about "true" vs "True" in reanahub/reana-workflow-controller#604 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit log cosmetics: the conventional commit scope should represent which component was touched by the change, so we should use "config" here:
feat(config): make Dask autoscaler configurable (#835)
(Unfortunately the previous commit slipped with feat(helm)
here even if this component does not have any Helm... We could override it using Release Please commit message overriding functionality to have nicer release news compilation.)
Also, please put Closes #NNN in the commit message body, so that we have the reference to the issue which this PR closes also locally, not only on GitHub.
e1f3718
to
4dbfce0
Compare
4dbfce0
to
95ea2df
Compare
closes reanahub/reana#834