-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbuilder #32
Jbuilder #32
Conversation
* Using external dep * Internal library * Library for opam export * Binary
I think it leads to less confusion. Might has well have the directories have the same names as the compiled artifacts |
tbh I'd rather capitalize |
@jaredly If you prefer it, you can capitalize the files if you like - we could also setup a case sensitive travis build to let us know if that introduces any issues. Regardless of if the package name is |
oh for sure! I was just converting from kebab to underscores, I'm totally fine with camel |
Nice! I'll just wait until the CI passes then merge! |
Happy to merge, but CI is not happy for some reason. Do you know what's up? |
oh funny, looks like there some duplication between |
Very good! Thank you @jaredly. Thank you @rgrinberg! This is a massive improvement. |
Does the readme of the project need to be updated with the move to JBuilder? |
yes! Do you feel like helping to document it? |
continuation of #30