fix: type of pipeable stream to allow objects with keys

reasonml · Sep 5, 2024 · 53d60fe · 53d60fe
1 parent fa71fa8
commit 53d60fe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/ReactDOMServerNode.re b/src/ReactDOMServerNode.re
@@ -24,14 +24,15 @@ type options = {
   progressiveChunkSize: option(int),
 };
 
-type pipeableStream = {
+type pipeableStream('a) = {
   /* Using empty object instead of Node.stream since Melange don't provide a binding to node's Stream (https://nodejs.org/api/stream.html) */
-  pipe: Js.t({.}) => unit,
+  pipe: Js.t({..} as 'a) => unit,
   abort: unit => unit,
 };
 
 [@mel.module "react-dom/server"]
-external renderToPipeableStream: (React.element, options) => pipeableStream =
+external renderToPipeableStream:
+  (React.element, options) => pipeableStream('a) =
   "renderToPipeableStream";
 
 let renderToPipeableStream =

diff --git a/src/ReactDOMServerNode.rei b/src/ReactDOMServerNode.rei
@@ -24,9 +24,9 @@ type options = {
   progressiveChunkSize: option(int),
 };
 
-type pipeableStream = {
+type pipeableStream('a) = {
   /* Using empty object instead of Node.stream since Melange don't provide a binding to node's Stream (https://nodejs.org/api/stream.html) */
-  pipe: Js.t({.}) => unit,
+  pipe: Js.t({..} as 'a) => unit,
   abort: unit => unit,
 };
 
@@ -45,4 +45,4 @@ let renderToPipeableStream:
     ~progressiveChunkSize: int=?,
     React.element
   ) =>
-  pipeableStream;
+  pipeableStream('a);