Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new PPX name in the error messages #800

Merged
merged 1 commit into from
Oct 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ppx/reason_react_ppx.ml
Original file line number Diff line number Diff line change
Expand Up @@ -658,8 +658,8 @@ let jsxMapper =
Ocaml_common.Location.prerr_warning pattern.ppat_loc
(Preprocessor
(Printf.sprintf
"react-jsx-ppx: optional argument annotations must \
have an explicit `option` type. Did you mean \
"reason-react-ppx: optional argument annotations \
must have an explicit `option` type. Did you mean \
`option(%s)=?`?"
currentType)))
| _ -> ()
Expand Down Expand Up @@ -696,7 +696,7 @@ let jsxMapper =
(list, Some txt)
| Pexp_fun (Nolabel, _, pattern, _expression) ->
Location.raise_errorf ~loc:pattern.ppat_loc
"react-jsx-ppx: react.component refs only support plain arguments \
"reason-react-ppx: react.component refs only support plain arguments \
and type annotations."
| _ -> (list, None)
[@@raises Invalid_argument]
Expand Down Expand Up @@ -965,7 +965,7 @@ let jsxMapper =
((fun a -> a), false, unerasableIgnoreExp expression)
else
Location.raise_errorf ~loc:pattern.ppat_loc
"react-jsx-ppx: props need to be labelled arguments.\n\
"reason-react-ppx: props need to be labelled arguments.\n\
\ If you are working with refs be sure to wrap with \
React.forwardRef.\n\
\ If your component doesn't have any props, use () \
Expand Down
Loading