test: add to runtest + fix bindings #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, just realized we were running jest explicitly in CI. Happy to roll that part back (I think I get confused because I expect |
as tests are launched explicitly in ci
anmonteiro
reviewed
Nov 26, 2023
| @@ -84,7 +84,7 @@ module Simulate = { | |||
|
|
|||
| external document: Dom.document = "document"; | |||
|
|
|||
| [@mel.send] | |||
| [@mel.return nullable] [@mel.send] | |||
There was a problem hiding this comment.
for my understanding: we're adding @mel.return nullable because querySelector may return null or undefined and we want to convert it to an option?
There was a problem hiding this comment.
Actually it can only return null. https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelector
Maybe I should use null_to_opt? To be more specific.
There was a problem hiding this comment.
this might be a good idea, but no strong opinions
anmonteiro
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunsEdit: see belowjestas part ofruntestalias