-
-
Notifications
You must be signed in to change notification settings - Fork 83
Disable activeFill #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Disable activeFill #373
Conversation
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
src/themes/theme.ts
Outdated
/** | ||
* Disable all activeFill, elements will not change color on hover/selection | ||
*/ | ||
disableActiveFill?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this being on the theme - what about passing it as a option to the selection hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I’m not sure about the useSelect
hook, since we’re still going to have a second layer of active states connected to the instances of nodes/edges. But we can use the store. I’ve pushed an update to the store. Let me know your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it - i think this is probably fine but i probably wouldn't have put it in the store personally just to avoid bloat but not a big deal.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
#267
What is the new behavior?
Possible to add
disableActiveFill
to the themedisabled.mov
Does this PR introduce a breaking change?
Other information