Skip to content

Conversation

AntonJames-Sistence
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
#267

What is the new behavior?

Possible to add disableActiveFill to the theme

disabled.mov

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit a5773a4
🔍 Latest deploy log https://app.netlify.com/projects/reagraph/deploys/68a76e61325698000871f355
😎 Deploy Preview https://deploy-preview-373--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

/**
* Disable all activeFill, elements will not change color on hover/selection
*/
disableActiveFill?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this being on the theme - what about passing it as a option to the selection hook?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I’m not sure about the useSelect hook, since we’re still going to have a second layer of active states connected to the instances of nodes/edges. But we can use the store. I’ve pushed an update to the store. Let me know your thoughts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - i think this is probably fine but i probably wouldn't have put it in the store personally just to avoid bloat but not a big deal.

@amcdnl amcdnl requested a review from evgenoid August 21, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants