[FIX] cert

[Scratch-net]

Summary by CodeRabbit

• New Features

  • Added multiple new trusted root CA certificates to enhance certificate validation support.

• Bug Fixes

  • Updated and corrected formatting of some existing root CA certificates for improved compatibility.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Alex E seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Walkthrough

The changes update the @reclaimprotocol/tls package version to 0.0.5 and expand the list of trusted root CA certificates in both src/scripts/ca-template.ts and src/utils/root-ca.ts. Several new PEM-encoded certificates are added and some existing certificates are replaced with updated versions. No logic or control flow is altered.

Changes

File(s)	Change Summary
package.json	Incremented package version from 0.0.4 to 0.0.5.
src/scripts/ca-template.ts	Added Sectigo Public Server Authentication CA DV R36 certificate; fixed array formatting.
src/utils/root-ca.ts	Added multiple new root CA certificates; replaced two existing certificates with updated PEMs.

Sequence Diagram(s)

Not applicable: No new features or control flow changes introduced.

Estimated code review effort

3 (~45 minutes)

Possibly related PRs

• [FIX] Added GeoTrust TLS RSA CA G1 #3: Both PRs update root CA lists in src/utils/root-ca.ts and src/scripts/ca-template.ts, specifically adding or modifying certificates.

Suggested reviewers

• adiwajshing
• AbdulRashidReshamwala
• Sajjad21990

Poem

In a warren of code, where certs abound,
New roots are planted deep in the ground.
With PEMs in a row and commas in place,
The rabbits ensure a secure embrace.
Version hops ahead, secure and spry—
TLS carrots reaching for the sky! 🥕🔐

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-23T14_06_07_866Z-debug-0.log

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

package.json (1)

3-3: No issues – version bump looks fine

The bump to 0.0.5 is syntactically correct and confined to the version field.
Just make sure a matching tag / release-note entry is cut so consumers can pin to the new CA bundle.

src/scripts/ca-template.ts (1)

3-184: Single source-of-truth for the CA bundle would simplify maintenance

src/scripts/ca-template.ts and src/utils/root-ca.ts both embed identical PEM arrays.
Duplicating ~100 KB of literal strings bloats the bundle and invites drift.

Consider:

• Moving the list to a dedicated .pem or .json file committed once,
• Re-exporting it from both modules (fs.readFileSync in Node / import in bundlers).

That cuts the maintenance surface and prevents accidental divergence.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09c1f4b and cbbd05b.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

• package.json (1 hunks)
• src/scripts/ca-template.ts (1 hunks)
• src/utils/root-ca.ts (5 hunks)

👮 Files not reviewed due to content moderation or server errors (1)

• src/utils/root-ca.ts

🔇 Additional comments (2)

src/scripts/ca-template.ts (2)

147-147: Trailing comma now required – change is correct

Because the new certificate follows, adding a comma after the GeoTrust block is mandatory and you did that.
Nothing further here.

---

148-183: Validate that this cert is a true root CA before adding to ROOT_CAS

Please perform the following manual checks on the new Sectigo entry in src/scripts/ca-template.ts (lines 148–183):

• Verify it is self-signed (Issuer == Subject) and its Basic Constraints include CA:TRUE with pathLenConstraint=0.
• Confirm its SHA-256 fingerprint appears in Mozilla’s NSS root store.

If either check fails, this certificate belongs in your intermediate bundle—not in ROOT_CAS.