Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body nesting V2 #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Body nesting V2 #70

wants to merge 2 commits into from

Conversation

rcpeters
Copy link
Contributor

After testing in the wild the first version of was causing issues. This version will:

  • if the contentEl is type body create a new div
  • append all the body children into the new div
  • append the new div to the body
  • ressagin contentEl(body) to be the new div

@rcpeters
Copy link
Contributor Author

rcpeters commented May 3, 2022

I think a better pattern would to allow a function to be passed into the config. That way no old behavior is broken but 3rd parties can easily customize. Happy refactor if that sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant