Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added redraw re-export from the highlightRenderer #104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added redraw re-export from the highlightRenderer #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932f585
Added `redraw` re-export from the `highlightRenderer`
oleksandr-danylchenko Jun 6, 2024
183d229
Merge branch 'refs/heads/main' into #103-redraw-export
oleksandr-danylchenko Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions packages/text-annotator/src/TextAnnotator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ export interface TextAnnotator<E extends unknown = TextAnnotation> extends Annot

setStyle(style: HighlightStyleExpression | undefined): void;

redraw(force?: boolean): void;

// Returns true if successful (or false if the annotation is not currently rendered)
scrollIntoView(annotation: TextAnnotation): boolean;

Expand Down Expand Up @@ -87,9 +89,6 @@ export const createTextAnnotator = <E extends unknown = TextAnnotation>(
selectionHandler.setFilter(filter);
}

const setStyle = (style: HighlightStyleExpression | undefined) =>
highlightRenderer.setStyle(style);

const setUser = (user: User) => {
currentUser = user;
selectionHandler.setUser(user);
Expand All @@ -110,9 +109,6 @@ export const createTextAnnotator = <E extends unknown = TextAnnotation>(
}
}

const setVisible = (visible: boolean) =>
highlightRenderer.setVisible(visible);

const destroy = () => {
highlightRenderer.destroy();
selectionHandler.destroy();
Expand All @@ -127,11 +123,12 @@ export const createTextAnnotator = <E extends unknown = TextAnnotation>(
element: container,
getUser,
setFilter,
setStyle,
setStyle: highlightRenderer.setStyle.bind(highlightRenderer),
redraw: highlightRenderer.redraw.bind(highlightRenderer),
setUser,
setSelected,
setPresenceProvider,
setVisible,
setVisible: highlightRenderer.setVisible.bind(highlightRenderer),
on: lifecycle.on,
off: lifecycle.off,
scrollIntoView: scrollIntoView(container, store),
Expand Down