Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#71 Fixed losing the styleClass on W3CTextAnnotation parsing #72

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

#71 Fixed losing the styleClass on W3CTextAnnotation parsing #72

wants to merge 4 commits into from

Conversation

oleksandr-danylchenko
Copy link
Contributor

Issue

This PR resolves the #71 issue. Left there a detailed explanation behind the change

Changes Made

  1. Added the styleClass?: string type to the TextAnnotation model
  2. Added copying of the styleClass from the W3CTextAnnotation to the TextAnnotation
  3. Added error reporting when there are no targets on the annotation

@oleksandr-danylchenko

This comment was marked as outdated.

Sign in to view
@oleksandr-danylchenko
Copy link
Contributor Author

Merge candidate? Seems like a pretty small, but beneficial, change 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oleksandr-danylchenko