Refactor ranking metric map to be the same as Spark's
#2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, why draft PR triggers tests? @miguelgfierro @anargyri Can we disable that? |
This might be a solution: https://github.com/orgs/community/discussions/25722 we need to try it. Issue: #2005 |
loomlike
requested review from
gramhagen,
anargyri,
wutaomsft and
SimonYansenZhao
as code owners
|
@loomlike are the test failures related to the values of the metrics? I vaguely recall that we had found some bugs in the Spark implementation (or they were not matching the definitions), hence our own implementations for some of the metrics. |
|
@anargyri I think the error was coming from test group names (as I changed some of the tests names, e.g. test_python_precision -> test_python_precision_at_k). I added a new commit to fix them in the test group lists. Let's see if that works. Regarding the MAP, Spark added Regarding the definition of MAP vs. MAP@K, actually what we had before was just MAP based on Wikipedia definition as well as Spark's implementation. The community seems to follow the following definition:
which the Spark's |
|
Good, as long as the evaluation notebooks give the same metrics as before we should be fine. |
|
@loomlike if you get an error on DCO you can go to details and approve it. Only admins can do this. I've approved this one. |
miguelgfierro
previously requested changes
Oct 13, 2023
There was a problem hiding this comment.
@loomlike hey we got an internal security email and it seems that it is due to an unsecured version of TF.
That caused a lot of problems, as expected, some of the TF algos with the v1 API break. I tried to figure out a way to fix it, but I couldn't. See #2017
Until this is merged to main, we can't start new VMs for the tests because they will have the old TF version and will trigger the security issue.
So would you mind stop doing any new commit to this PR until the TF situation is fixed?
TF=💩
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
…2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
…2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: Jun Ki Min <[email protected]>
loomlike
force-pushed
the
jumin/evaluation
branch
from
3d9e888
to
86f3744
Compare
Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: Jun Ki Min <[email protected]>
SimonYansenZhao
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]>
SimonYansenZhao
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]>
SimonYansenZhao
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]>
SimonYansenZhao
added a commit
that referenced
this pull request
Feb 19, 2024
* Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to resolve #2018 Signed-off-by: Simon Zhao <[email protected]> * Exclude tensorflow versions that are not supported Signed-off-by: Simon Zhao <[email protected]> * Correct version comparison using packaging.version.Version Signed-off-by: Simon Zhao <[email protected]> * Capture importerror Signed-off-by: Simon Zhao <[email protected]> * Restrict tensorflow < 2.13 Signed-off-by: Simon Zhao <[email protected]> * Set tensorflow < 2.12 Signed-off-by: Simon Zhao <[email protected]> * Not triggering unit tests on Draft PR (#2033) * Not triggering unit tests on Draft PR Signed-off-by: Jun Ki Min <[email protected]> * Change a PR-triggering file to test Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Add missing kernelspec language Signed-off-by: Simon Zhao <[email protected]> * Remove scrapbook and papermill deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * data notebooks Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Merge multiline parameters into one line Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * [Fix] correct MIND data construction of user behavior history Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update hybrid to CF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace LayerRNNCell with AbstractRNNCell Signed-off-by: Simon Zhao <[email protected]> * Stop testing for deeprec Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating a jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added rst files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * license Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Weird warning with a link in the docstrings Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix docstring errors and replace .. note:: with Note: Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation dev Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Delete workflow and try via UI Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added again the workflow Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -rf Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -f Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * add git info Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token and pull before pushing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase and -Xtheirs Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * clean Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update documentation badge Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * install all deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * try adding other sphinx extensions Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refact model rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * comment geoimc and rlrmc docs until issue is fixed Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Reviewing other rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version and jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change the way we compile the documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Using the latest JB release Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Documentation working Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/requirements-doc.txt Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added comments by @SimonYansenZhao Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Upgrade versions of GitHub Actions See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Signed-off-by: Simon Zhao <[email protected]> * Update setup.py Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to disable sum and sum_component only Signed-off-by: Simon Zhao <[email protected]> * Upgrade AzureML docker image Signed-off-by: Simon Zhao <[email protected]> * Correct variable names Signed-off-by: Simon Zhao <[email protected]> * Install git in the Conda env Signed-off-by: Simon Zhao <[email protected]> * Disable test_xdeepfm_component_definition Signed-off-by: Simon Zhao <[email protected]> * Use latest CUDA Signed-off-by: Simon Zhao <[email protected]> * Correct GPU selection Signed-off-by: Simon Zhao <[email protected]> * Remove leading whitespaces in Dockerfile Signed-off-by: Simon Zhao <[email protected]> * Simplify azureml-test/action.yml Signed-off-by: Simon Zhao <[email protected]> * Install wget in Docker image Signed-off-by: Simon Zhao <[email protected]> * Update Signed-off-by: Simon Zhao <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Jun Ki Min <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Co-authored-by: thaiminhpv <[email protected]>
gogetron
pushed a commit
to gogetron/recommenders
that referenced
this pull request
Apr 11, 2024
* Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to resolve recommenders-team#2018 Signed-off-by: Simon Zhao <[email protected]> * Exclude tensorflow versions that are not supported Signed-off-by: Simon Zhao <[email protected]> * Correct version comparison using packaging.version.Version Signed-off-by: Simon Zhao <[email protected]> * Capture importerror Signed-off-by: Simon Zhao <[email protected]> * Restrict tensorflow < 2.13 Signed-off-by: Simon Zhao <[email protected]> * Set tensorflow < 2.12 Signed-off-by: Simon Zhao <[email protected]> * Not triggering unit tests on Draft PR (recommenders-team#2033) * Not triggering unit tests on Draft PR Signed-off-by: Jun Ki Min <[email protected]> * Change a PR-triggering file to test Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (recommenders-team#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Add missing kernelspec language Signed-off-by: Simon Zhao <[email protected]> * Remove scrapbook and papermill deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * data notebooks Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Merge multiline parameters into one line Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (recommenders-team#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * [Fix] correct MIND data construction of user behavior history Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update hybrid to CF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace LayerRNNCell with AbstractRNNCell Signed-off-by: Simon Zhao <[email protected]> * Stop testing for deeprec Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (recommenders-team#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (recommenders-team#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating a jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added rst files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * license Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Weird warning with a link in the docstrings Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix docstring errors and replace .. note:: with Note: Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation dev Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Delete workflow and try via UI Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added again the workflow Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -rf Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -f Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * add git info Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token and pull before pushing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase and -Xtheirs Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * clean Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update documentation badge Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * install all deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * try adding other sphinx extensions Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refact model rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * comment geoimc and rlrmc docs until issue is fixed Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Reviewing other rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version and jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change the way we compile the documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Using the latest JB release Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Documentation working Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/requirements-doc.txt Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added comments by @SimonYansenZhao Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Upgrade versions of GitHub Actions See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Signed-off-by: Simon Zhao <[email protected]> * Update setup.py Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to disable sum and sum_component only Signed-off-by: Simon Zhao <[email protected]> * Upgrade AzureML docker image Signed-off-by: Simon Zhao <[email protected]> * Correct variable names Signed-off-by: Simon Zhao <[email protected]> * Install git in the Conda env Signed-off-by: Simon Zhao <[email protected]> * Disable test_xdeepfm_component_definition Signed-off-by: Simon Zhao <[email protected]> * Use latest CUDA Signed-off-by: Simon Zhao <[email protected]> * Correct GPU selection Signed-off-by: Simon Zhao <[email protected]> * Remove leading whitespaces in Dockerfile Signed-off-by: Simon Zhao <[email protected]> * Simplify azureml-test/action.yml Signed-off-by: Simon Zhao <[email protected]> * Install wget in Docker image Signed-off-by: Simon Zhao <[email protected]> * Update Signed-off-by: Simon Zhao <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Jun Ki Min <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Co-authored-by: thaiminhpv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mapto be the same as Spark's.map_at_ktomapwhich basically the same as Spark'smeanAveragePrecisionmap_at_kto be the same as Spark'smeanAveragePrecisionAtNote: With this changes, some notebook tests are failing.
I'll need to update the expected values for
map_at_kmetrics for those notebooks, or simply to usemapthat is our previousmap_at_k.Related Issues
#2002
#1990
#1702
References
Checklist:
staging branchand not tomain branch.