Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test #2116

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Test #2116

wants to merge 1 commit into from

Conversation

simonzhaoms
Copy link
Collaborator

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

@miguelgfierro
Copy link
Collaborator

@SimonYansenZhao it is complaining about SSL in Movilens:

E           MaxRetryError: HTTPSConnectionPool(host='files.grouplens.org', port=443): Max retries exceeded with url: /datasets/movielens/ml-100k.zip (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1007)')))

miguelgfierro
miguelgfierro reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests are failing for the same reason https://github.com/recommenders-team/recommenders/actions/runs/9647294629/job/26607924976

miguelgfierro
miguelgfierro reviewed Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking due to #2121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro left review comments

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@SimonYansenZhao SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonzhaoms @miguelgfierro