Fix ImplicitCF failing if not using stratified split #2024 #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavo
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
miguelgfierro
merged commit 9f630e3
into
recommenders-team:staging
1 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a variable called
n_users_in_trainto allow ImplicitCF to work even if a user is in test but not in train.Related Issues
References
Checklist:
git commit -s -m "your commit message".staging branchAND NOT TOmain branch.