Staging to main: Fix to NewsRec, LightFM to extras, issue with scipy #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: miguelgfierro <[email protected]>
Made the following grammatical corrections to line 97 of the file: - "has into account" should be "takes into account". - "Riemannian conjugate gradients optimization" should be "Riemannian conjugate gradient optimization" (singular form). - "and following a geometric approach" should be "and follows a geometric approach".
Update jupyter dep to accomodate Colab
Fix typo in README.md
Signed-off-by: David Davó <[email protected]>
Signed-off-by: David Davó <[email protected]>
Removed deprecated numpy alias
Deprecated use of dict in SeriesGroupBy.agg
Fix ImplicitCF failing if not using stratified split #2024
This reverts commit b73ee01.
It turns out I ran incorrect tests and the evaluation module was not really working
Signed-off-by: David Davó <[email protected]>
Pin numpy version to 1
Revert and fix python evaluation
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Remove LightFM from core package
…ibute Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Updated Issue Template with "Willingness to Contribute" Section for issue #2032
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Modified 2 files to update newsrec model
* Set scipy<=1.13.1 Signed-off-by: Simon Zhao <[email protected]> * Leave a comment as a reminder Signed-off-by: Simon Zhao <[email protected]> --------- Signed-off-by: Simon Zhao <[email protected]>
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
SimonYansenZhao
approved these changes
Jul 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Staging to main: Fix to NewsRec, LightFM to extras, issue with scipy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
References
Checklist:
git commit -s -m "your commit message".staging branchAND NOT TOmain branch.