[pull] master from eclipse-theia:master#397
Merged
Merged
Conversation
* feat(terminal): linkify file:// URLs printed in the terminal A printed file:// URL was inert: UrlLinkProvider only matches http(s), and FileLinkProvider's path regex excludes ':' so the URL survives only as a scheme-less remainder its guard now skips. Add a dedicated FileUriLinkProvider that matches file:// URLs, parses them as whole URIs (preserving authority for UNC/localhost forms), validates via FileService, and opens the file in the editor via OpenerService. * feat(terminal): open file:// links at :line:column * refactor(terminal): dedupe file link providers and fix regex re-entrancy Collect regex matches synchronously before awaiting so concurrent provideLinks calls cannot corrupt the shared g-flag lastIndex. Extract the shared file-open helpers (isValidFileURI, openURI) into AbstractFileOpeningLinkProvider, which both FileLinkProvider and FileUriLinkProvider extend. Signed-off-by: Dmitrij Rozdestvensky <dmitrij.rozdestvensky@juliahub.com>
Align the button order in the untitled workspace exit dialog to match
the layout of most other dialogs ("Cancel" -> "Don't Save" -> "Save").
See `ShouldSaveDialog` in packages/core/src/browser/saveable.ts for
reference.
…r command disambiguation (#17661) Co-authored-by: Nina Doschek <ndoschek@eclipsesource.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )