forked from opendatahub-io/kubeflow
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #92 from harshad16/sync-stable
sync master branch with upstream opendatahub stable branch
- Loading branch information
Showing
7 changed files
with
11 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,4 @@ | ||
# Kubeflow Contributor Guide | ||
### Review and Merge Process | ||
|
||
Welcome to the Kubeflow project! We'd love to accept your patches and | ||
contributions to this project. Please read the | ||
[contributor's guide in our docs](https://www.kubeflow.org/docs/about/contributing/). | ||
|
||
The contributor's guide | ||
|
||
* shows you where to find the Contributor License Agreement (CLA) that you need | ||
to sign, | ||
* helps you get started with your first contribution to Kubeflow, | ||
* and describes the pull request and review workflow in detail, including the | ||
OWNERS files and automated workflow tool. | ||
- Once the PR is submitted, you can either select specific reviewers or let the bot to select reviewers [automatically](https://prow.ci.openshift.org/plugins?repo=opendatahub-io%2Fnotebooks). | ||
- For the PR to be merged, it must receive 2 reviews from the repository [approvals/reviewers](/OWNERS). Following that, an `/approve` comment must be added by someone with approval rights. If the author of the PR has approval rights, it is preferred that they perform the merge action. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
approvers: | ||
- atheo89 | ||
- caponetto | ||
- harshad16 | ||
- jiridanek | ||
- jstourac | ||
- paulovmr | ||
|
||
reviewers: | ||
- atheo89 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
components/notebook-controller/config/overlays/openshift/params.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
varReference: | ||
- path: spec/template/spec/containers/image | ||
kind: Deployment | ||
kind: Deployment |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,4 @@ resources: | |
- manager.yaml | ||
- service.yaml | ||
configurations: | ||
- params.yaml | ||
- params.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
varReference: | ||
- path: spec/template/spec/containers/image | ||
kind: Deployment | ||
kind: Deployment |